rapids_find_package propagates variables from find_package #54
+108
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
robertmaynard
force-pushed
the
bug/find_package_is_macro
branch
from
361e533 to
59f2aaa
Compare
Fixes rapidsai#53 The conversion of `rapids_find_package` to being a macro instead of a function allows it to properly propagate both common `find_package` variables and uncommon ones ( CUDAToolkit_LIBRARY_ROOT ).
robertmaynard
force-pushed
the
bug/find_package_is_macro
branch
from
59f2aaa to
0eb31ac
Compare
dantegd
approved these changes
Aug 6, 2021
kkraus14
approved these changes
Aug 6, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
The conversion of
rapids_find_packageto being a macro instead of a function allows it to properly propagate both commonfind_packagevariables and uncommon ones ( CUDAToolkit_LIBRARY_ROOT ).