-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded whitespace from json #544
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-24.04
from
robertmaynard:bug/remove_unneeded_whitespace_from_json
Feb 26, 2024
Merged
Remove unneeded whitespace from json #544
rapids-bot
merged 4 commits into
rapidsai:branch-24.04
from
robertmaynard:bug/remove_unneeded_whitespace_from_json
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
New feature or request
non-breaking
Introduces a non-breaking change
3 - Ready for Review
Ready for review by team
labels
Feb 26, 2024
KyleFromNVIDIA
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What program did you use to find these? I think we'd do well to add it as a pre-commit hook.
@KyleFromNVIDIA I added a hook called |
bdice
approved these changes
Feb 26, 2024
robertmaynard
force-pushed
the
bug/remove_unneeded_whitespace_from_json
branch
from
February 26, 2024 15:53
e7fd2b9
to
35d4e89
Compare
AyodeAwe
approved these changes
Feb 26, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
feature request
New feature or request
non-breaking
Introduces a non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While the JSON spec allows whitespace before or after any structural character, some json linters complain about it. So we remove the 'offending' whitespace.
Checklist