Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded whitespace from json #544

Conversation

robertmaynard
Copy link
Contributor

Description

While the JSON spec allows whitespace before or after any structural character, some json linters complain about it. So we remove the 'offending' whitespace.

Checklist

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Feb 26, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner February 26, 2024 14:45
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What program did you use to find these? I think we'd do well to add it as a pre-commit hook.

@robertmaynard
Copy link
Contributor Author

What program did you use to find these? I think we'd do well to add it as a pre-commit hook.

Brought up as a style issue during #530 and I manually found this with grep.

@bdice Is looking at adding the pre-commit hook currently

@robertmaynard robertmaynard requested a review from a team as a code owner February 26, 2024 15:14
@bdice
Copy link
Contributor

bdice commented Feb 26, 2024

@KyleFromNVIDIA I added a hook called pretty-format-json. It seems to do the job we want.

@robertmaynard robertmaynard force-pushed the bug/remove_unneeded_whitespace_from_json branch from e7fd2b9 to 35d4e89 Compare February 26, 2024 15:53
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 12651da into rapidsai:branch-24.04 Feb 26, 2024
16 checks passed
@robertmaynard robertmaynard deleted the bug/remove_unneeded_whitespace_from_json branch February 26, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants