Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nvbench version for faster benchmark runs #549

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Feb 29, 2024

Description

This PR bumps the nvbench version to fetch the latest feature added in NVIDIA/nvbench#151 which should largely reduce nvbench runtime.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@PointKernel PointKernel marked this pull request as ready for review February 29, 2024 20:07
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change labels Mar 1, 2024
@robertmaynard
Copy link
Contributor

@PointKernel Can you open a draft PR for cudf that verifies it builds with this update please.

Really happy to have more efficient nvbench runs

@PointKernel
Copy link
Member Author

Opened rapidsai/cudf#15206 to verify this version bump against cudf.

@robertmaynard
Copy link
Contributor

@PointKernel You could with this being merged now?

@PointKernel
Copy link
Member Author

@robertmaynard Yes, please go for it.

@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit bd31e9c into rapidsai:branch-24.04 Mar 4, 2024
16 checks passed
@PointKernel PointKernel deleted the bump-nvbench-version branch March 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants