Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand rapids-cmake cpm docs #613

Merged
merged 9 commits into from
May 24, 2024

Conversation

robertmaynard
Copy link
Contributor

Description

Provide a more detailed high level overview of the rapids-cmake cpm functions and what you can do with them

Fixes ##551

Checklist

@robertmaynard robertmaynard requested a review from a team as a code owner May 22, 2024 19:41
@robertmaynard
Copy link
Contributor Author

Requires #614 for CI failures

docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Show resolved Hide resolved
@robertmaynard robertmaynard added doc Documentation feature request New feature or request non-breaking Introduces a non-breaking change labels May 23, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions, otherwise LGTM.

docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
docs/cpm.rst Outdated Show resolved Hide resolved
@robertmaynard robertmaynard removed the feature request New feature or request label May 24, 2024
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 8139598 into rapidsai:branch-24.08 May 24, 2024
15 checks passed
@robertmaynard robertmaynard deleted the docs/improve_cpm_docs branch May 24, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants