Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings #678

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings #678

merged 1 commit into from
Aug 20, 2024

Conversation

robertmaynard
Copy link
Contributor

Description

Updated to CPM version 0.40.2 so that we don't se any policy CMP0169 ( FetchContent_Populate() is deprecated ) warnings

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Aug 20, 2024
@robertmaynard robertmaynard requested a review from a team as a code owner August 20, 2024 15:45
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 2a80e4c into rapidsai:branch-24.10 Aug 20, 2024
16 checks passed
@robertmaynard robertmaynard deleted the fea/update_cpm_to_0.40.2 branch August 20, 2024 19:31
jameslamb added a commit to jameslamb/rapids-cmake that referenced this pull request Aug 20, 2024
@jameslamb
Revert "Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings (r…
ccfa740 
…apidsai#678)"

This reverts commit 2a80e4c.
This was referenced Aug 20, 2024
Merged
Open
rapids-bot bot pushed a commit that referenced this pull request Aug 20, 2024
@jameslamb
Revert "Update to CPM 0.40.2 to fix CMake 3.30 deprecation warnings (#…
82bc63b 
…678)" (#679)

Proposes reverting #678.

See #680 for context.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @bdice