Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow projects to override version.json information #74

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Allow projects to override version.json information #74

merged 5 commits into from
Sep 8, 2021

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented Aug 31, 2021 •
edited
Loading

Fixes #73

Introduces OVERRIDE argument to rapids_cpm_init() and the rapids_cpm_package_override command.

Both of these allow consuming projects to inject new urls/repository/tag/etc for rapids-cmake cpm pre-configured packages

@robertmaynard
Allow projects to override version.json information
cd7cee9 
Fixes rapidsai#73

Introduces `OVERRIDE` argument to rapids_cpm_init() and the
rapids_cpm_package_override command.

Both of these allow consuming projects to inject new
urls/repository/tag/etc for rapids-cmake cpm pre-configured packages
@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 2 - In Progress Currenty a work in progress labels Aug 31, 2021
@robertmaynard robertmaynard mentioned this pull request Aug 31, 2021
Closed
@robertmaynard
Copy link
Contributor Author

@dantegd Would be okay using this design? Is the requirement of writing a json file to onerous?

@robertmaynard robertmaynard marked this pull request as ready for review September 8, 2021 12:20
@robertmaynard robertmaynard added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 2 - In Progress Currenty a work in progress labels Sep 8, 2021
@robertmaynard
Copy link
Contributor Author

Had offline signoff on the design.

@robertmaynard robertmaynard force-pushed the fea/rapids-cpm-override branch from 315c585 to 785e41f Compare September 8, 2021 15:44
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fc7f91f into rapidsai:branch-21.10 Sep 8, 2021
@robertmaynard robertmaynard deleted the fea/rapids-cpm-override branch September 8, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Allow projects to override version.json information
1 participant
@robertmaynard