Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch cuco filter alignment fix to unblock RAPIDS CI #744

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fetch cuco filter alignment fix to unblock RAPIDS CI #744

merged 1 commit into from
Jan 17, 2025

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Jan 17, 2025 •
edited
Loading

Description

This PR bumps cuco version to fetch a bloom filter alignment fix.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@PointKernel PointKernel requested a review from a team as a code owner January 17, 2025 02:19
@PointKernel PointKernel self-assigned this Jan 17, 2025
@PointKernel PointKernel added 3 - Ready for Review Ready for review by team non-breaking Introduces a non-breaking change improvement Improves an existing functionality and removed 3 - Ready for Review Ready for review by team labels Jan 17, 2025
@PointKernel PointKernel marked this pull request as draft January 17, 2025 02:27
@PointKernel PointKernel added the 2 - In Progress Currenty a work in progress label Jan 17, 2025
@PointKernel
Copy link
Member Author

PointKernel commented Jan 17, 2025 •
edited
Loading

bdice
bdice approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving so this can be merged when downstream tests are validated.

@mhaseeb123 mhaseeb123 mentioned this pull request Jan 17, 2025
Merged
3 tasks
@PointKernel
Copy link
Member Author

Some of the CI failures in cuGraph are due to connection issues and are unrelated to the changes in this PR. Since this update involves bloom filter implementations in cuco, which are not used by cuGraph, these CI failures should not impact the PR's changes. I am proceeding with the merge to unblock the cuDF bug fix.

@PointKernel
Copy link
Member Author

/merge

@PointKernel PointKernel removed the 2 - In Progress Currenty a work in progress label Jan 17, 2025
@PointKernel PointKernel marked this pull request as ready for review January 17, 2025 21:20
@rapids-bot rapids-bot bot merged commit f2e0216 into rapidsai:branch-25.02 Jan 17, 2025
21 checks passed
@PointKernel PointKernel deleted the fetch-filter-fix branch January 17, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees

@PointKernel PointKernel

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PointKernel @bdice