cpm tests now download less components and can be run in parallel. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
improvement
robertmaynard
added
3 - Ready for Review
robertmaynard
force-pushed
the
reduce_github_fetches
branch
2 times, most recently
from
9c53ef1 to
120c4f0
Compare
This allows multiple sibling consumers of rapids-version.cmake without issue. Previously you would include the file a second time and no variable would be created.
The cpm tests previously would each fetch at minimum the CPM module from github, and possibly other components. Now we pre-popluate a shared cache with each rapids-cmake package and the cpm module. The end result of this is two fold. First we reduce the amount of network requests, and testing is quicker as we can run more tests in parallel.
robertmaynard
force-pushed
the
reduce_github_fetches
branch
from
120c4f0 to
c4d29b8
Compare
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
As part of #81 the `setup_cpm_cache.cmake` file was moved and refactored. In that PR all callers of setup_cpm_cache() had been updated, but I missed a couple of tests that just included the file. This removes those unneeded inclusions. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: None URL: #82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cpm tests previously would each fetch at minimum the CPM module from github, and possibly other components. Now we pre-popluate a shared cache with each rapids-cmake package and the cpm module.
The end result of this is two fold. First we reduce the amount of network requests, and testing is quicker as we can run
more tests in parallel.