Skip to content

Commit

Permalink
Build wheels alongside conda CI (#1182)
Browse files Browse the repository at this point in the history
* Build wheels alongside conda CI

* Remove package-dir param from wheel test/publish

* wheel-publish needs wheel-build

* Adjust versioneer-override param name

* Add smoketest for abbreviated arm PR CI

* make wheel builds depend on `checks`

* Address PR feedback

* Removed some wheel parameters

Co-authored-by: AJ Schmidt <[email protected]>
Co-authored-by: AJ Schmidt <[email protected]>
  • Loading branch information
3 people authored Jan 6, 2023
1 parent 0c16507 commit 3732b31
Show file tree
Hide file tree
Showing 5 changed files with 59 additions and 52 deletions.
23 changes: 23 additions & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,26 @@ jobs:
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
wheel-build:
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-build.yml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
repo: rapidsai/rmm
branch: ${{ inputs.branch }}
sha: ${{ inputs.sha }}
date: ${{ inputs.date }}
package-name: rmm
package-dir: python
skbuild-configure-options: "-DRMM_BUILD_WHEELS=ON"
wheel-publish:
needs: wheel-build
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-publish.yml@main
with:
build_type: ${{ inputs.build_type || 'branch' }}
repo: rapidsai/rmm
branch: ${{ inputs.branch }}
sha: ${{ inputs.sha }}
date: ${{ inputs.date }}
package-name: rmm
20 changes: 20 additions & 0 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
- conda-cpp-tests
- conda-python-build
- conda-python-tests
- wheel-build
- wheel-tests
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/pr-builder.yaml@cuda-118
checks:
Expand Down Expand Up @@ -46,3 +48,21 @@ jobs:
uses: rapidsai/shared-action-workflows/.github/workflows/conda-python-tests.yaml@cuda-118
with:
build_type: pull-request
wheel-build:
needs: checks
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-build.yml@main
with:
build_type: pull-request
package-dir: python
package-name: rmm
skbuild-configure-options: "-DRMM_BUILD_WHEELS=ON"
wheel-tests:
needs: wheel-build
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-test.yml@main
with:
build_type: pull-request
package-name: rmm
test-unittest: "python -m pytest -v ./python/rmm/tests"
test-smoketest: "python ./ci/wheel_smoke_test.py"
11 changes: 11 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,14 @@ jobs:
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
wheel-tests:
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/wheels-manylinux-test.yml@main
with:
build_type: nightly
repo: rapidsai/rmm
branch: ${{ inputs.branch }}
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
package-name: rmm
test-unittest: "python -m pytest -v ./python/rmm/tests"
52 changes: 0 additions & 52 deletions .github/workflows/wheels.yml

This file was deleted.

5 changes: 5 additions & 0 deletions ci/wheel_smoke_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import rmm

if __name__ == "__main__":
buf = rmm.DeviceBuffer(size=100)
assert buf.size == 100

0 comments on commit 3732b31

Please sign in to comment.