Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Standardize shared_mutex usage #1332

Closed
vyasr opened this issue Aug 30, 2023 · 0 comments · Fixed by #1563
Closed

[FEA] Standardize shared_mutex usage #1332

vyasr opened this issue Aug 30, 2023 · 0 comments · Fixed by #1563
Labels
? - Needs Triage Need team to review and classify feature request New feature or request good first issue Good for newcomers

Comments

@vyasr
Copy link
Contributor

vyasr commented Aug 30, 2023

Is your feature request related to a problem? Please describe.
statistics_resource_adapter contains two std::shared_lock<std::shared_timed_mutex> types that could instead be std::shared_mutex now that we require C++ 17.

Describe the solution you'd like
We should audit the codebase for other instances of std::shared_lock<std::shared_timed_mutex> and make the necessary changes everywhere.
@vyasr vyasr added feature request New feature or request ? - Needs Triage Need team to review and classify labels Aug 30, 2023
@harrism harrism added the good first issue Good for newcomers label Jan 18, 2024
@harrism harrism mentioned this issue May 28, 2024
Merged
3 tasks
madsbk added a commit to madsbk/rmm that referenced this issue May 28, 2024
@madsbk
tracking_resource_adaptor: use std::shared_mutex
89827ad 
Closes rapidsai#1332
@rapids-bot rapids-bot bot closed this as completed in #1563 Jun 6, 2024
rapids-bot bot pushed a commit that referenced this issue Jun 6, 2024
@madsbk
Add a stack to the statistics resource (#1563)
6902af9 
In order to enable more fine-grained statistics, this PR adds a _stack_ to `statistics_resource_adaptor`

Closes #1332

Authors:
  - Mads R. B. Kristensen (https://github.com/madsbk)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Lawrence Mitchell (https://github.com/wence-)

URL: #1563
@github-project-automation github-project-automation bot moved this from Todo to Done in RMM Project Board Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request good first issue Good for newcomers
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a stack to the statistics resource madsbk/rmm
2 participants
@harrism @vyasr