-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add a pinned memory resource #136
Comments
I would like to work on this issue. May I know more details on this issue? |
You can look at the The Then update the tests to test the new resource: https://github.com/rapidsai/rmm/blob/branch-0.10/tests/mr/mr_tests.cpp#L88 |
Alright thanks for the information! I'll work on it and send a PR 😄 |
This was done in PR ( #272 ), right? |
The difference is in a |
Oh, I didn't realize pinned memory could be treated like device memory. Had assumed it was just page locked host memory. Is that not right? What am I missing here? |
It is just that, but CUDA devices are able to access it directly as if it were device memory. |
Would it make sense to use |
Conceptually yes. However as Jake pointed out in another issue/PR, the problem is we have specific device_memory_resource tests which check that the returned pointer is a device pointer. I think we could actually expand that to instead just check that the memory is device accessible. To do that we would just check that the type is NOT |
This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. |
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d. |
Superseded by #618 |
Is your feature request related to a problem? Please describe.
There's currently no memory resource for allocating pinned memory (e.g.,
cudaHostAlloc
).Describe the solution you'd like
There should be a
pinned_memory_resource
.Additional context
Inspired by rapidsai/cudf#2872 (comment)
The text was updated successfully, but these errors were encountered: