Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java pinned memory pool allocator #2872

Merged
merged 5 commits into from
Sep 30, 2019

Conversation

jlowe
Copy link
Contributor

@jlowe jlowe commented Sep 26, 2019

Adds a pinned memory pool on the Java side along with a runtime Java config option, ai.rapids.cudf.prefer-pinned, that specifies whether host buffers should use pinned memory if possible. Even if pinned memory buffers are preferred, the pinned memory pool must be initialized first or host buffers will fallback to paged memory.

Host buffers that need paged memory can use the new allocate overload with a boolean parameter to request the pinned memory allocator not be used.

@jlowe jlowe added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer labels Sep 26, 2019
@jlowe jlowe requested a review from a team as a code owner September 26, 2019 14:40
@jlowe jlowe self-assigned this Sep 26, 2019
@jrhemstad
Copy link
Contributor

@harrism should we add a pinned memory resource to RMM?

@harrism
Copy link
Member

harrism commented Sep 26, 2019

@jrhemstad yes I think that makes sense. In RMM I like the ID of having a non-pool MR for every memory type, and then we can use any of those MRs as a heap resource for a pool MR, making it flexible. All your memory are belong to RMM. :)

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #2872 into branch-0.10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.10    #2872   +/-   ##
============================================
  Coverage        86.53%   86.53%           
============================================
  Files               48       48           
  Lines             9000     9000           
============================================
  Hits              7788     7788           
  Misses            1212     1212

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570ad62...6fd47c3. Read the comment docs.

Copy link
Contributor

@razajafri razajafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to @jlowe about the best fit approach instead of getting the largest chunk which can be visited when/if need arises

@razajafri razajafri merged commit 1cf627a into rapidsai:branch-0.10 Sep 30, 2019
@jlowe jlowe deleted the java-pinned-mempool branch September 10, 2021 15:43
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond Java Affects Java cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants