Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite rmm::exec_policy to take a cuda::mr::async_resource_ref instead of a device_memory_resource* #1448

Closed
Tracked by #1445
miscco opened this issue Jan 30, 2024 · 0 comments · Fixed by #1449
Closed
Tracked by #1445

Rewrite rmm::exec_policy to take a cuda::mr::async_resource_ref instead of a device_memory_resource* #1448

miscco opened this issue Jan 30, 2024 · 0 comments · Fixed by #1449
Assignees
@miscco
Labels
feature request New feature or request

Comments

@miscco
Copy link
Contributor

miscco commented Jan 30, 2024

No description provided.

@miscco miscco mentioned this issue Jan 30, 2024
Open
miscco added a commit to miscco/rmm that referenced this issue Jan 30, 2024
@miscco
Move rmm::exec_policy over to async_resource_ref
207622a 
This rewrites `rmm::exec_policy` to take a `cuda::std::async_resource_ref` instead of a plain `rmm::device_memory_resource*`. This is completely opaque to the user as the underlying `rmm::thrust_allocator` already takes a `cuda::mr::async_resource_ref`

Fixes rapidsai#1448

Closes
@miscco miscco mentioned this issue Jan 30, 2024
Merged
3 tasks
miscco added a commit to miscco/rmm that referenced this issue Jan 30, 2024
@miscco
Move rmm::exec_policy over to async_resource_ref
aba5c97 
This rewrites `rmm::exec_policy` to take a `cuda::std::async_resource_ref` instead of a plain `rmm::device_memory_resource*`. This is completely opaque to the user as the underlying `rmm::thrust_allocator` already takes a `cuda::mr::async_resource_ref`

Fixes rapidsai#1448

Closes
@harrism harrism added the feature request New feature or request label Jan 30, 2024
@rapids-bot rapids-bot bot closed this as completed in #1449 Feb 2, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in RMM Project Board Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miscco miscco

Labels
feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change rmm::exec_policy to take async_resource_ref miscco/rmm
2 participants
@harrism @miscco