Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Configure CUDA Malloc Async tests to be skipped in unsupported environments #985

Closed
ajschmidt8 opened this issue Feb 23, 2022 · 0 comments · Fixed by #986
Closed

[BUG] Configure CUDA Malloc Async tests to be skipped in unsupported environments #985

ajschmidt8 opened this issue Feb 23, 2022 · 0 comments · Fixed by #986
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@ajschmidt8
Copy link
Member

ajschmidt8 commented Feb 23, 2022 •
edited
Loading

It was recently discovered in #984 that the bash command that's responsible for invoking our Google Test binaries has some invalid quotes around the * character which prevent all of the tests from being called (link). However, after moving the quotes in #984, some additional tests are run that weren't being run before. In particular, this causes issues with tests that rely on CUDA malloc async since there are no runtime checks that enable them to be skipped on CUDA versions that are less than 11.2.

To address this issue, the following changes should be made:

  • Add a runtime check to Google Tests to ensure that they are skipped on CUDA < 11.2 environments if they rely on CUDA malloc async
  • Move the quotes here to not include the * character, as done in Fix bash command for running tests #984.
@ajschmidt8 ajschmidt8 added bug Something isn't working ? - Needs Triage Need team to review and classify labels Feb 23, 2022
@ajschmidt8 ajschmidt8 mentioned this issue Feb 23, 2022
Closed
@rongou rongou mentioned this issue Feb 23, 2022
Merged
@rapids-bot rapids-bot bot closed this as completed in #986 Feb 25, 2022
rapids-bot bot pushed a commit that referenced this issue Feb 25, 2022
@rongou
Skip async mr tests when cuda runtime/driver < 11.2 (#986)
ace0964 
The cuda async allocator was added in 11.2, if the runtime or driver is older than that the tests wouldn't work.

Fixes #985

Authors:
  - Rong Ou (https://github.com/rongou)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip async mr tests when cuda runtime/driver < 11.2 rongou/rmm
1 participant
@ajschmidt8