Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wheel build to PR #1167

Closed
wants to merge 2 commits into from
Closed

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 29, 2022

Description

Add support for building wheels to PRs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 2 - In Progress Currently a work in progress non-breaking Non-breaking change improvement Improvement / enhancement to an existing function ci labels Nov 29, 2022
@vyasr vyasr self-assigned this Nov 29, 2022
@github-actions github-actions bot removed the ci label Nov 29, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Nov 29, 2022

@ajschmidt8 @sevagh I have some questions on what we want to accomplish here. Broadly speaking we'll need to figure out exactly how much we want to/can align the pip and conda workflows.

  • What would you like to see here to determine what degree of wheel building we can support in CI?
  • Is there more unification of the conda and wheels workflows that you would like to see?
  • Some of the logic in the wheels.yaml workflow probably doesn't make sense to include here. I don't think we need the versioneer override and such in pr.yaml. However, we will need them if we add the same jobs into build.yaml for nightlies. Does that all sound right @sevagh?
  • I don't think we want to litter k8s with copies of the package from every single PR build. Should we simply add an option to skip the upload so that PR artifacts don't get saved? What about the intermediate artifacts that are uploaded to the S3 buckets?
  • What's the best way to handle the build/test split? Currently the wheels workflow in the shared actions repo is monolithic and handles the build matrix and testing (run on different executors selected by labels). Do we need to separate the build and test into separate workflows to match the conda builds? I think it may be necessary to support the build.yaml/test.yaml split used for nightlies.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@d132e52). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             branch-23.02   #1167   +/-   ##
==============================================
  Coverage                ?   0.00%           
==============================================
  Files                   ?       5           
  Lines                   ?     406           
  Branches                ?       0           
==============================================
  Hits                    ?       0           
  Misses                  ?     406           
  Partials                ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr
Copy link
Contributor Author

vyasr commented Dec 21, 2022

This PR has been superseded by #1182

@vyasr vyasr closed this Dec 21, 2022
@vyasr vyasr deleted the feat/wheels_ci branch December 21, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants