Remove HTML builds of librmm #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for review
raydouglass
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
This means that docs should be disabled for 24.02+ aka nightly here right?
Might apply to stable/23.12 too?
|
@raydouglass yup that PR is rapidsai/docs#464 |
|
/merge |
bdice
added a commit
to bdice/rmm
that referenced
this pull request
Jul 10, 2024
This reverts commit 77b5500.
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
This reverts commit 77b5500. See: rapidsai/docs#517 (review) We need to have librmm docs published in order to enable cross-linking of librmm from libcudf docs. From discussion with @raydouglass, we don't need to link to them publicly on docs.rapids.ai, as they are already included in the rmm docs (both C++ and Python). The librmm docs will just be used to cross-reference from libcudf docs. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We no longer require separate librmm doc builds since they are incorporated into the Sphinx build now.
Checklist