Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt the rmm::device_async_resource_ref alias #1454

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Adopt the rmm::device_async_resource_ref alias #1454

merged 3 commits into from
Feb 2, 2024

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Feb 1, 2024

Before we had that alias we would introduce one locally. This is not needed anymore, so remove the local ones, as this helps readability.

@miscco miscco requested a review from a team as a code owner February 1, 2024 08:34
@miscco miscco requested review from rongou and jrhemstad February 1, 2024 08:34
@github-actions github-actions bot added the cpp Pertains to C++ code label Feb 1, 2024
@miscco miscco requested a review from harrism February 1, 2024 08:35
@miscco miscco added tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general non-breaking Non-breaking change and removed cpp Pertains to C++ code labels Feb 1, 2024
@miscco miscco force-pushed the adopt_resource_ref_alias branch from 702c8ea to 73881da Compare February 1, 2024 08:36
@github-actions github-actions bot added the cpp Pertains to C++ code label Feb 1, 2024
@miscco
Adopt the rmm::device_async_resource_ref alias
267415b 
Before we had that alias we would introduce one locally. This is not needed anymore, so remove the local ones, as this helps readability.
@miscco miscco force-pushed the adopt_resource_ref_alias branch from 73881da to 267415b Compare February 1, 2024 09:42
harrism
harrism requested changes Feb 1, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some includes not needed anymore. Otherwise looks great, thanks for this cleanup.

include/rmm/device_buffer.hpp Outdated Show resolved Hide resolved
include/rmm/device_uvector.hpp Outdated Show resolved Hide resolved
include/rmm/mr/device/thrust_allocator_adaptor.hpp Outdated Show resolved Hide resolved
tests/mr/device/mr_ref_test.hpp Show resolved Hide resolved
@miscco miscco added the improvement Improvement / enhancement to an existing function label Feb 1, 2024
@harrism
Copy link
Member

harrism commented Feb 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9caab39 into rapidsai:branch-24.04 Feb 2, 2024
47 checks passed
@miscco miscco deleted the adopt_resource_ref_alias branch February 2, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@rongou rongou rongou approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees
No one assigned
Labels
cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miscco @harrism @rongou