Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated cuda_async_memory_resource constructor that takes thrust::optional parameters #1535

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Remove deprecated cuda_async_memory_resource constructor that takes thrust::optional parameters #1535

merged 2 commits into from
Apr 16, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Apr 16, 2024

Description

Fixes #1534
Fixes #1530

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism added breaking Breaking change improvement Improvement / enhancement to an existing function labels Apr 16, 2024
@harrism harrism requested a review from a team as a code owner April 16, 2024 01:10
@harrism harrism requested review from miscco and bdice April 16, 2024 01:10
@github-actions github-actions bot added the cpp Pertains to C++ code label Apr 16, 2024
@harrism harrism mentioned this pull request Apr 16, 2024
Closed
3 tasks
@harrism harrism mentioned this pull request Apr 16, 2024
Closed
@harrism harrism changed the title Removed deprecated cuda_async_memory_resource constructor that takes thrust::optional parameters Remove deprecated cuda_async_memory_resource constructor that takes thrust::optional parameters Apr 16, 2024
@harrism
Copy link
Member Author

harrism commented Apr 16, 2024

\merge

@harrism
Copy link
Member Author

harrism commented Apr 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit 7ed529f into rapidsai:branch-24.06 Apr 16, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@miscco miscco miscco approved these changes

Assignees
No one assigned
Labels
breaking Breaking change cpp Pertains to C++ code improvement Improvement / enhancement to an existing function
Projects
RMM Project Board
Status: Done
Milestone
No milestone
3 participants
@harrism @miscco @bdice