Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thrust CMake Guide link in README.md #1593

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

pauleonix
Copy link
Contributor

@pauleonix pauleonix commented Jun 26, 2024

Description

The README still linked to the archived Thrust repo instead of the new CCCL repo for the Thrust CMake Guide.

Replace link.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Jun 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@wence- wence- changed the base branch from main to branch-24.08 June 26, 2024 09:23
@wence- wence- requested a review from a team as a code owner June 26, 2024 09:23
@wence- wence- requested a review from msarahan June 26, 2024 09:23
@wence-
Copy link
Contributor

wence- commented Jun 26, 2024

Thanks @pauleonix! One minor thing, for reasons, we don't merge to main, but rather a release branch. This is currently branch-24.08. I've retargetted your PR to that base branch, but could you please rebase your (one) commit on top of branch-24.08 and force-push?

@wence- wence- added doc Documentation non-breaking Non-breaking change labels Jun 26, 2024
The README still linked to the archived Thrust repo instead of the new CCCL repo for the Thrust CMake Guide.
@wence- wence- removed request for a team and msarahan June 26, 2024 10:31
@wence-
Copy link
Contributor

wence- commented Jun 26, 2024

/ok to test

@wence-
Copy link
Contributor

wence- commented Jun 26, 2024

/merge

@wence-
Copy link
Contributor

wence- commented Jun 26, 2024

Thanks!

@harrism
Copy link
Member

harrism commented Jun 26, 2024

Must be a problem with the GPU on the node running the failing test, seems unrelated. Unfortunately unlike most PRs, this one isn't giving me the option to rerun failed jobs.

@wence-
Copy link
Contributor

wence- commented Jun 26, 2024

Must be a problem with the GPU on the node running the failing test, seems unrelated. Unfortunately unlike most PRs, this one isn't giving me the option to rerun failed jobs.

I was able to now, so have kicked that run off again.

@rapids-bot rapids-bot bot merged commit cc53275 into rapidsai:branch-24.08 Jun 26, 2024
58 checks passed
@pauleonix pauleonix deleted the patch-1 branch July 2, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[DOC] Outdated link in README.md
3 participants