Add documentation for CPM usage #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
- Add section in README.md that describes issue with CPM's single argument syntax. - Update link to CPM.cmake repo (old link redirected to this new one). - Add optional INTERFACE argument to CMake snippets for completeness. Co-authored-by: Robert Maynard <[email protected]>
|
Instead of rebasing and force pushing, for PR branches you should merge. Force pushing disassociates github comments from the code, so we discourage it in RAPIDS. Thanks! |
|
@harrism Thanks for the feedback! I was seduced by the possibility to just amend my previous commit instead of creating a new one. I wasn't aware of the problem regarding comments here on GitHub. I really need to stop overthinking adding small commits 😅 Is the CI broken? |
|
/ok to test |
No, but we must authorise in case you are doing anything nefarious |
|
Fixed the spelling error that triggered codespell. |
|
/ok to test |
|
/ok to test |
harrism
reviewed
Jul 22, 2024
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1594
Checklist