-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RMM_USE_NVTX cmake option to provide localized control of NVTX for RMM #1602
Conversation
Verified that with this change by default RMM NVTX ranges appear in profiles, but I can add |
One final question before we merge: should this be |
Oh I didn't realize there was already precedence for a project-specific NVTX config. Makes sense to be consistent. |
@robertmaynard is this ready to merge? |
Can someone with permissions update the PR labels or grant me the permissions to do so? I think this is ready to go. Would really like to see this get into the 24.08 release. |
/merge |
Description
Adds a new RMM_USE_NVTX cmake option that defaults to the prior USE_NVTX setting if not set. If RMM_USE_NVTX is OFF, it stubs out the RMM_FUNC_RANGE macro which is used for RMM's NVTX ranges, effectively disabling NVTX within RMM yet leaving it enabled for the rest of the project using RMM.
Closes #1595
Checklist