Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise NumPy 2 support and test against numba==0.57 and numpy==1.23 #1612

Closed
wants to merge 4 commits into from

Conversation

seberg
Copy link
Contributor

@seberg seberg commented Jul 15, 2024

Description

This is mostly gh-1606, but continues it:

  • Also implementing wheel testing
  • Start advertising support for NumPy 2 (which is no problem for RMM).

It then uses this to enforce that we run tests with numba==0.57 and numpy==1.23 so that tests are not only run with NumPy 2 when bumping.
This is not particularly important for RMM, but interesting for other RAPIDS libraries.

Planned changes:

  • Matthew suggested renaming earliest, I would like to rename it to oldest, but I cannot without creating a branch in the shared workflow (I think).
  • Need to merge the shared workflow branch before merging.
  • Since the NumPy dependency is very light, I just used numpy<3 as a pin. We could also use a rule like current+2 throughout RAPIDS.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Jul 15, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@seberg
Copy link
Contributor Author

seberg commented Jul 16, 2024

Closing, going to continue on original PR.

@seberg seberg closed this Jul 16, 2024
@seberg
Copy link
Contributor Author

seberg commented Jul 16, 2024

Sorry for the noise, will continue here after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci conda Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants