Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefetch factory. #1625

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Remove prefetch factory. #1625

merged 1 commit into from
Jul 25, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jul 23, 2024

Description

PR #1608 added a prefetch resource adaptor. However, per issue #1616, we want to remove the adaptor factories like make_prefetch_adaptor in favor of constructors with CTAD. I am removing the prefetch adaptor factory because it has not yet been released, and thus can be deleted without deprecation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner July 23, 2024 21:27
@bdice bdice requested review from rongou and jrhemstad July 23, 2024 21:27
@github-actions github-actions bot added the cpp Pertains to C++ code label Jul 23, 2024
@bdice bdice mentioned this pull request Jul 23, 2024
Closed
@vyasr vyasr added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 23, 2024
@bdice
Copy link
Contributor Author

bdice commented Jul 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit 8c20e14 into rapidsai:branch-24.08 Jul 25, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism harrism approved these changes

@rongou rongou rongou approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees
No one assigned
Labels
cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdice @rongou @harrism @vyasr