Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install headers into ${CMAKE_INSTALL_INCLUDEDIR} #1633

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Install headers into ${CMAKE_INSTALL_INCLUDEDIR} #1633

merged 2 commits into from
Jul 31, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

Instead of installing into a hard-coded include directory, install to ${CMAKE_INSTALL_INCLUDEDIR}, which defaults to include.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 31, 2024 16:42
@github-actions github-actions bot added the CMake label Jul 31, 2024
@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 31, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 514ba80 into rapidsai:branch-24.10 Jul 31, 2024
57 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@harrism
Copy link
Member

harrism commented Jul 31, 2024

All PRs in RMM should have an associated Issue, please. I added this requirement to the PR template in 24.08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleFromNVIDIA @jakirkham @harrism @robertmaynard @bdice