Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD_SHARED_LIBS option defaulting to ON #1702

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Oct 9, 2024

Description

This means that downstream libraries that get their fmt dependency from RMM will use -DFMT_SHARED in the compile command: this matches what the rapids combined devcontainers do, so we get sccache hits.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner October 9, 2024 16:34
@github-actions github-actions bot added the CMake label Oct 9, 2024
@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Oct 9, 2024
@wence-
Copy link
Contributor Author

wence- commented Oct 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit 69a297d into rapidsai:branch-24.12 Oct 9, 2024
58 checks passed
@wence- wence- deleted the wence/fix/1701 branch October 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA] Default to BUILD_SHARED_LIBS=ON in cmakelists
2 participants