Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs warning #1706

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix docs warning #1706

merged 1 commit into from
Oct 16, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 16, 2024

Description

Closes #1705.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner October 16, 2024 20:55
@github-actions github-actions bot added the Python Related to RMM Python API label Oct 16, 2024
@@ -22,8 +23,8 @@
# -- Project information -----------------------------------------------------

project = "rmm"
copyright = "2020-2023, NVIDIA"
author = "NVIDIA"
copyright = f"2018-{datetime.datetime.today().year}, NVIDIA Corporation"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need this across rapids repos 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I have tried to implement it everywhere when I see a hardcoded end year.

The start year is just wrong - I suspect a copy-paste issue. RMM has definitely been around since 2018.

@bdice bdice added doc Documentation non-breaking Non-breaking change labels Oct 16, 2024
@bdice bdice self-assigned this Oct 16, 2024
@bdice
Copy link
Contributor Author

bdice commented Oct 16, 2024

Yay! This fixed the docs builds. I will merge this.

@bdice
Copy link
Contributor Author

bdice commented Oct 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit 50e60a8 into rapidsai:branch-24.12 Oct 16, 2024
55 checks passed
rapids-bot bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request Oct 16, 2024
This fixes a failure in docs builds that comes from a warning.

See rapidsai/rmm#1705 and rapidsai/rmm#1706 for more information.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Docs builds are failing with a warning about get_html_theme_path
2 participants