Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use rapids-generate-pip-constraints to pin to oldest dependencies in CI #1716

Merged
merged 3 commits into from
Nov 7, 2024
Merged

use rapids-generate-pip-constraints to pin to oldest dependencies in CI #1716

merged 3 commits into from
Nov 7, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 31, 2024 •
edited
Loading

Description

Follow-up to #1613

Similar to rapidsai/cudf#17131

Proposes using the new rapids-generate-pip-constraints tool from gha-tools to generate a list of pip constraints pinning to the oldest supported verisons of dependencies here.

Notes for Reviewers

How I tested this

wheel-tests:

And the testing of the general approach in rapidsai/gha-tools#114 (comment)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added non-breaking Non-breaking change 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function labels Oct 31, 2024
@github-actions github-actions bot added the ci label Oct 31, 2024
@jameslamb jameslamb removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 1, 2024
@jameslamb jameslamb changed the title WIP: use rapids-generate-pip-constraints to pin to oldest dependencies in CI use rapids-generate-pip-constraints to pin to oldest dependencies in CI Nov 1, 2024
@jameslamb jameslamb marked this pull request as ready for review November 1, 2024 03:57
@jameslamb jameslamb requested a review from a team as a code owner November 1, 2024 03:57
@jameslamb jameslamb requested a review from raydouglass November 1, 2024 03:57
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 771ccdc into rapidsai:branch-24.12 Nov 7, 2024
58 checks passed
@jameslamb jameslamb deleted the deps-tools branch November 7, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@raydouglass raydouglass Awaiting requested review from raydouglass raydouglass is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice