Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce wheel size limits, README formatting in CI #1726

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#110

Proposes adding 2 types of validation on wheels in CI, to ensure we continue to produce wheels that are suitable for PyPI.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added non-breaking Non-breaking change 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function labels Nov 13, 2024
@github-actions github-actions bot added Python Related to RMM Python API ci labels Nov 13, 2024
@jameslamb jameslamb removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 13, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] enforce wheel size limits, README formatting in CI enforce wheel size limits, README formatting in CI Nov 13, 2024
@jameslamb jameslamb requested a review from bdice November 13, 2024 06:13
@jameslamb jameslamb marked this pull request as ready for review November 13, 2024 06:13
@jameslamb jameslamb requested review from a team as code owners November 13, 2024 06:13
@jameslamb jameslamb requested a review from a team as a code owner November 13, 2024 17:22
"cuda-python": (
"https://nvidia.github.io/cuda-python/cuda-bindings/",
None,
),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is blocked in this repo, because docs builds are failing like this:

/__w/rmm/rmm/python/rmm/docs/docstring of rmm.pylibrmm.device_buffer.DeviceBuffer.prefetch:10: WARNING: py:attr reference target not found: cuda.bindings.runtime.cudaCpuDeviceId

(build link)

@harrism pushed a fix for that to #1724 (5330063), but I'm not sure how close that PR is to being merged.

Proposing the same fix here, in this ready-to-merge PR, to help unblock CI.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving docs fix to unblock CI.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 56f3a46 into rapidsai:branch-24.12 Nov 13, 2024
58 checks passed
@jameslamb jameslamb deleted the wheel-validation branch November 13, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants