Treat deprecation warnings as errors and fix deprecation warnings in replay benchmark #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
bug
rongou
approved these changes
Nov 13, 2024
bdice
approved these changes
Nov 13, 2024
|
/merge |
|
You may have to push an empty commit to get CI to run properly on this again. There were errors in upstream GHA workflows/actions that disrupted these runs, and a simple rerun via the GUI will pull cached versions of those so it won't fix the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1727
Contributes to rapidsai/build-planning#26
-Wno-error=deprecated-declarationsrmm::logger()in reply benchmark with supportedRMM_LOG_INFOmacros.Note the latter duplicates a change in #1724 which allows the two PRs to be merged independently.
Checklist