Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query total memory in failure_callback_resource_adaptor tests #1734

Merged

Conversation

harrism
Copy link
Member

@harrism harrism commented Nov 19, 2024

Description

Fixes #1733 by querying total device memory and using twice as much in tests that are expected to fail allocation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner November 19, 2024 23:38
@github-actions github-actions bot added the Python Related to RMM Python API label Nov 19, 2024
@harrism harrism added bug Something isn't working non-breaking Non-breaking change Python Related to RMM Python API tests Related to unit tests and removed Python Related to RMM Python API labels Nov 19, 2024
@harrism
Copy link
Member Author

harrism commented Nov 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3b5f6af into rapidsai:branch-24.12 Nov 20, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Related to RMM Python API tests Related to unit tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] FailureCallbackResourceAdaptor pytests fail on GPUs with more than 100GiB of device memory
2 participants