Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bindings layout for all cuda-python imports. #1756

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 9, 2024

Description

Closes #1755.

Replaces #1675.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Dec 9, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Related to RMM Python API label Dec 9, 2024
@bdice bdice added feature request New feature or request non-breaking Non-breaking change labels Dec 9, 2024
@bdice bdice self-assigned this Dec 9, 2024
@bdice bdice marked this pull request as ready for review December 9, 2024 23:41
@bdice bdice requested a review from a team as a code owner December 9, 2024 23:41
python/rmm/rmm/_cuda/gpu.py Outdated Show resolved Hide resolved
Co-authored-by: Matthew Murray <[email protected]>
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdice
Copy link
Contributor Author

bdice commented Dec 10, 2024

/merge

@rapids-bot rapids-bot bot merged commit c3841dd into rapidsai:branch-25.02 Dec 10, 2024
57 of 58 checks passed
rapids-bot bot pushed a commit that referenced this pull request Dec 17, 2024
Following #1756, we no longer need to guard against this deprecation warning.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Matthew Murray (https://github.com/Matt711)
  - James Lamb (https://github.com/jameslamb)

URL: #1768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA] Use new cuda-python cuda.bindings layout for imports
3 participants