Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rmm._lib #1765

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Remove rmm._lib #1765

merged 2 commits into from
Dec 14, 2024

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Dec 13, 2024

Description

Closes #1762

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added feature request New feature or request Python Related to RMM Python API breaking Breaking change labels Dec 13, 2024
@Matt711 Matt711 self-assigned this Dec 13, 2024
@Matt711 Matt711 requested a review from a team as a code owner December 13, 2024 18:10
@Matt711 Matt711 added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Dec 13, 2024
@Matt711
Copy link
Contributor Author

Matt711 commented Dec 13, 2024

Marking as "DO NOT MERGE" until I open up the other PRs arounds RAPIDS. I'll link them here one they're ready.

@Matt711 Matt711 removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Dec 13, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We are not blocked by any upstream refactoring, as far as I can tell. (cuOpt is not blocked by this change: https://github.com/rapidsai/cuopt/pull/2148#issuecomment-2542826073)

Thanks @Matt711!

@bdice
Copy link
Contributor

bdice commented Dec 14, 2024

/merge

@rapids-bot rapids-bot bot merged commit bf606ef into rapidsai:branch-25.02 Dec 14, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA] Remove deprecated rmm._lib
2 participants