Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pre-commit.ci] pre-commit autoupdate #1778

Merged
merged 5 commits into from
Jan 7, 2025
Merged

[pre-commit.ci] pre-commit autoupdate #1778

merged 5 commits into from
Jan 7, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 6, 2025

@pre-commit-ci
[pre-commit.ci] pre-commit autoupdate
f42b914 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.8.2 → v0.8.6](astral-sh/ruff-pre-commit@v0.8.2...v0.8.6)
- [github.com/pre-commit/mirrors-clang-format: v16.0.6 → v19.1.6](pre-commit/mirrors-clang-format@v16.0.6...v19.1.6)
- [github.com/rapidsai/dependency-file-generator: v1.16.0 → v1.17.0](rapidsai/dependency-file-generator@v1.16.0...v1.17.0)
@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner January 6, 2025 21:38
@pre-commit-ci pre-commit-ci bot requested a review from gforsyth January 6, 2025 21:38
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@pre-commit-ci pre-commit-ci bot requested a review from a team as a code owner January 6, 2025 21:38
@pre-commit-ci pre-commit-ci bot requested review from harrism and vyasr January 6, 2025 21:38
@github-actions github-actions bot added the cpp Pertains to C++ code label Jan 6, 2025
@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 6, 2025
@bdice bdice marked this pull request as draft January 6, 2025 21:53
@bdice
Copy link
Contributor

bdice commented Jan 6, 2025

We cannot merge any updates to clang-format without unifying those changes across RAPIDS. However, there is no way to tell that to pre-commit.ci in the config, as updates cannot be disabled for individual packages.

We basically have two options:

  1. Mark this PR as "DO NOT MERGE" and put it in draft mode. Each quarter, pre-commit.ci will continue to push new changes to this PR. We will ignore those updates. If I close this PR, pre-commit.ci will open a new one, so it doesn't really help to close it. We will manage pre-commit hook updates on our own schedule.
  2. Alternatively, I can manually revert the clang-format version change and we can merge this PR.

I am leaning towards the second option. I'll see how it goes.

bdice
bdice reviewed Jan 6, 2025
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor

bdice commented Jan 6, 2025

pre-commit.ci autofix

bdice
bdice approved these changes Jan 6, 2025
View reviewed changes
tests/mr/device/arena_mr_tests.cpp Outdated Show resolved Hide resolved
tests/mr/device/failure_callback_mr_tests.cpp Outdated Show resolved Hide resolved
@bdice bdice marked this pull request as ready for review January 6, 2025 22:57
@bdice
Copy link
Contributor

bdice commented Jan 6, 2025

/ok to test

@github-actions github-actions bot removed the cpp Pertains to C++ code label Jan 6, 2025
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Jan 6, 2025
@bdice bdice self-assigned this Jan 7, 2025
@bdice
Copy link
Contributor

bdice commented Jan 7, 2025

/merge

@rapids-bot rapids-bot bot merged commit d70bd4b into branch-25.02 Jan 7, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@gforsyth gforsyth Awaiting requested review from gforsyth gforsyth is a code owner automatically assigned from rapidsai/ci-codeowners

@harrism harrism Awaiting requested review from harrism harrism was automatically assigned from rapidsai/rmm-cpp-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr was automatically assigned from rapidsai/rmm-cpp-codeowners

Assignees

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdice