Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build RMM's Python bindings with PTDS #480

Closed
wants to merge 3 commits into from
Closed

[WIP] Build RMM's Python bindings with PTDS #480

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2ee35f
Build RMM's Python bindings with PTDS
jakirkham Aug 20, 2020
5352719
Add missing PTDS entry to setup.py
pentschev Nov 19, 2020
f67d34c
Merge rapidsai/branch-0.17 into jakirkham/bld_w_ptds
jakirkham Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
## Improvements

- PR #477 Just use `None` for `strides` in `DeviceBuffer`
- PR #480 Build RMM's Python bindings with PTDS

## Bug Fixes

Expand Down
6 changes: 6 additions & 0 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ def get_cuda_version_from_header(cuda_include_dir):
except Exception:
nthreads = 0

define_macros = [
("CUDA_API_PER_THREAD_DEFAULT_STREAM", None),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this make this a command line option? How does this work? (Not that familiar with setup.py)

]

include_dirs = [
"../include/rmm",
"../include",
Expand Down Expand Up @@ -125,6 +129,7 @@ def get_cuda_version_from_header(cuda_include_dir):
],
libraries=["cuda", "rmm"],
language="c++",
define_macros=define_macros,
extra_compile_args=["-std=c++14"],
)
],
Expand All @@ -148,6 +153,7 @@ def get_cuda_version_from_header(cuda_include_dir):
],
libraries=["cuda", "rmm"],
language="c++",
define_macros=define_macros,
extra_compile_args=["-std=c++14"],
)
],
Expand Down