Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] unpin spdlog so that it can move to 1.8.1 or above #589

Closed
wants to merge 2 commits into from
Closed

[REVIEW] unpin spdlog so that it can move to 1.8.1 or above #589

wants to merge 2 commits into from

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Oct 1, 2020

The problem from #542 should be fixed.

@harrism @kkraus14

@rongou rongou requested review from a team as code owners October 1, 2020 04:24
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@harrism
Copy link
Member

harrism commented Oct 1, 2020

add to whitelist

@harrism harrism added 3 - Ready for review Ready for review by team CMake conda labels Oct 1, 2020
kkraus14
kkraus14 previously approved these changes Oct 1, 2020
View reviewed changes
@kkraus14
Copy link
Contributor

kkraus14 commented Oct 1, 2020 •
edited
Loading 

/opt/conda/envs/rapids/conda-bld/librmm_1601527198390/work/build/_deps/spdlog-src/include/spdlog/fmt/bundled/format.h(3677): error: a literal operator template must have a template parameter list equivalent to "<char ...>"

1 error detected in the compilation of "/tmp/tmpxft_00000345_00000000-6_thrust_allocator_tests.cpp1.ii".
make[2]: *** [tests/CMakeFiles/THRUST_ALLOCATOR_TEST.dir/build.make:82: tests/CMakeFiles/THRUST_ALLOCATOR_TEST.dir/mr/device/thrust_allocator_tests.cu.o] Error 1

Looks like there's still an issue in 1.8.1 for CUDA 10.1 / 10.2?

@kkraus14 kkraus14 dismissed their stale review October 1, 2020 06:36

cuda 10.x issues

@rongou
Copy link
Contributor Author

rongou commented Oct 1, 2020

@kkraus14 hmm it's possible. I only built it with cuda 11. Let me try the older versions.

@harrism
Copy link
Member

harrism commented Oct 1, 2020 •
edited
Loading

This was the error that prevented us using spdlog 1.8.0 before. I expected it to be fixed by fmtlib/fmt#1818 which I think is in spdlog 1.8.1 but I'm not positive...

ajschmidt8
ajschmidt8 reviewed Oct 1, 2020
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the spdlog version in the integration repo will also need to be updated.

https://github.com/rapidsai/integration/blob/branch-0.16/conda/recipes/versions.yaml#L116

@rongou
Copy link
Contributor Author

rongou commented Oct 1, 2020

Argh looks like that fix just missed the fmt release so it didn't get into spdlog. I guess we'll just have to wait for a bit.

@rongou rongou closed this Oct 1, 2020
@rongou rongou deleted the unpin-spdlog branch October 9, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 left review comments

@kkraus14 kkraus14 kkraus14 left review comments

Assignees
No one assigned
Labels
3 - Ready for review Ready for review by team CMake conda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rongou @GPUtester @harrism @kkraus14 @ajschmidt8