Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove required flag from shared-actions param #258

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

msarahan
Copy link
Contributor

@msarahan msarahan commented Nov 4, 2024

This caused existing workflows that do not yet add this parameter to fail. Other workflows did not have this parameter as a required parameter.

These parameters are part of a rework of how shared actions get called. It is described in the readme in https://github.com/rapidsai/shared-actions

@msarahan msarahan requested a review from a team as a code owner November 4, 2024 16:27
@msarahan msarahan requested a review from AyodeAwe November 4, 2024 16:27
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msarahan

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in case the answer to my question is "yes this is fine", as it seems that maybe you're trying to unblock CI in some other repo.

But don't we need to supply a default if there are repos out there not passing this configuration? What's going to happen if a null or empty string reaches this?

- name: Checkout actions
uses: actions/checkout@v4
with:
repository: ${{inputs.shared_actions_repo}}
ref: ${{inputs.shared_actions_ref}}
path: ./shared-actions

@msarahan msarahan merged commit c0d50d2 into branch-24.12 Nov 4, 2024
@msarahan msarahan deleted the no-required-shared-actions branch November 4, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants