-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all-to-all benchmark #760
base: branch-0.21
Are you sure you want to change the base?
Conversation
cc @jakirkham @gjoseph92 you both may find this PR interesting for running networking experiments which compare Tornado, UCX, and Asyncio |
This prevets asyncio.iscoroutinefunction from returning False in Python < 3.8
rerun tests |
It might be interesting to try with uvloop as well. Since the event loop is largely handled by libuv in C, would expect that performs better than asyncio alone |
Thanks for the suggestion @jakirkham , I added that now. |
rerun tests |
1 similar comment
rerun tests |
I will be curious to see the results that come out of this. If anyone has anything preliminary that they want to share I highly encourage that :) |
@@ -0,0 +1,240 @@ | |||
import argparse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this in tests/
or would it make sense to include in benchmarks/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still thinking about it. I don't want it in tests, but I want a test there (for the UCX part only). However, a lot of the code is going to be shared and we don't have a good place currently where that common code would be visible to both. I'm not even sure the non-UCX code should live in this repo as we'll soon upstream it to OpenUCX, so it doesn't really make sense to have non-UCX code there. I'm still thinking of an appropriate place for this, if you have any suggestions, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that makes sense. Will think about it as well.
To run the benchmark in single-node:
To run each process separately, allowing multi-node as well: