This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
allow temp_memory_handler to allocate memory for multiple times #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into tmp_allocator
chuangz0
added
non-breaking
chuangz0
approved these changes
Apr 28, 2024
raydouglass
reviewed
Apr 29, 2024
ci/test_python.sh
Outdated
| @@ -49,6 +49,7 @@ PACKAGES="pylibwholegraph" | |||
| rapids-mamba-retry install \ | |||
| --channel "${CPP_CHANNEL}" \ | |||
| --channel "${PYTHON_CHANNEL}" \ | |||
| 'mkl<2024.1.0' \ | |||
There was a problem hiding this comment.
Is this change temporary or permanent?
The PR doesn't mention this change.
There was a problem hiding this comment.
This change in test_python.sh is actually another PR(#162) addressing mkl and PyTorch conflict. And PR 162 is now merged into wholegraph. I rebased current PR on PR 162 to pass CI before PR 162 is merged. In conclusion, this change in test_python.sh has already be merged. Sorry for the confusion. I will wait for a PR to be merged, and then rebase on it next time.
|
/merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to issue 76, which allows temp_memory_handler to allocate memory for multiple times.