Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Adding Docs #35

Merged
merged 11 commits into from
Jul 6, 2023
Merged

Adding Docs #35

merged 11 commits into from
Jul 6, 2023

Conversation

BradReesWork
Copy link
Member

creating docs

@BradReesWork BradReesWork marked this pull request as draft June 30, 2023 17:23
@BradReesWork BradReesWork changed the title draft set of files Adding Docs Jun 30, 2023
@BradReesWork BradReesWork added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 5, 2023
@BradReesWork BradReesWork requested a review from acostadon July 5, 2023 20:22
@BradReesWork BradReesWork marked this pull request as ready for review July 6, 2023 12:37
@BradReesWork BradReesWork requested a review from dongxuy04 July 6, 2023 13:06
@dongxuy04
Copy link
Contributor

LGTM, thanks! I think we can merge this and I will add more doc pages to the repo.

dongxuy04
dongxuy04 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@dongxuy04 dongxuy04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I think we can merge this and I will add more doc pages to the repo.

acostadon
acostadon reviewed Jul 6, 2023
View reviewed changes
docs/wholegraph/source/installation/source_build.md
* `cmake` version 3.23.1+

__CUDA:__
* CUDA 11.8+
Copy link
Contributor

@acostadon acostadon Jul 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it CUDA 11.8+ will 11.7 not work?

acostadon
acostadon approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to build the docs but the changes look good as far as I can tell.

@BradReesWork
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit d058288 into rapidsai:refactoring Jul 6, 2023
@dongxuy04 dongxuy04 mentioned this pull request Jul 9, 2023
Merged
rapids-bot bot pushed a commit that referenced this pull request Jul 12, 2023
@dongxuy04
Update docs (#36)
6a758cf 
Updated docs

- Added more comments in codes
- Merged #35 and enabled docs 
- Added some MarkDown docs

Authors:
  - https://github.com/dongxuy04

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Don Acosta (https://github.com/acostadon)

URL: #36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acostadon acostadon acostadon approved these changes

@dongxuy04 dongxuy04 dongxuy04 approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BradReesWork @dongxuy04 @acostadon