This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Remove libcugraphops dependency and add CUDA 12 CI support #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongxuy04
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Jul 20, 2023
dongxuy04
changed the title
Remove libcugraphops dependency
Remove libcugraphops dependency and add CUDA 12 CI support
Jul 20, 2023
Merged
tingyu66
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a suggestion and a question. LGTM, otherwise.
Co-authored-by: Tingyu Wang <[email protected]>
@BradReesWork Shall we merge this PR into refactoring? |
BradReesWork
approved these changes
Jul 25, 2023
/merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
libcugraphops
is only needed to run GNN applications, not required bylibwholgraph
orpylibwholegraph
, just remove it from dependency.Updated YAML files to support CUDA 12 CI.
Fix exit code in
ci/test_python.sh
and also skip python test for CUDA 12 as no public stable pytorch package.