Fix: Move href, src, and formaction from reflected attributes to regular attributes #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar attributes The mapping between props and attributes for those keys is not exactly an identity, e.g. if the provided URL is a relative one like , reading the attribute's value will return the same relative URL, but reading the prop will return a computed absolute URL that includes the domain name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping between props and attributes for those keys is not exactly an identity. Writing to these as attrs or props behaves identically, but reading the values out of the DOM does not, e.g. if the provided value is a relative URL like "/page.html", reading the attribute's value will return the same relative URL, but reading the prop's value will return a computed absolute URL that includes the domain name.