Minter Access Control #105
Conversation
|
Thank you! |
|
Nice one! |
|
Nice one @NicolasMahe! |
|
@evgenynacu Would this PR be in conflict with the fix we're deploying to restrict minting with private |
came here to ask the same question! any input would be much appreciated! current private createtoken is a great start thanks for that. This would give more flexibility on top of it ideally. |
|
Hey guys Sorry for the delay |
Implement feedback on Mint Access Control
Comments implemented 👍 The state variable |
|
Hi @NicolasMahe, I leave some comments, not critical, I hope You are agree. Together we`ll try to generate this code better))) |
Feedbacks implemented 👍 One conversation open for more modification. |
| __MinterAccessControl_init_unchained(); | ||
| } | ||
|
|
||
| function version() public view returns (uint256) { |
There was a problem hiding this comment.
For version identification we use smth like that:
bytes4 constant public V2 = bytes4(keccak256("V2"));
You can see it: exchange-v2/contracts/LibOrderDataV2.sol
So may You use this constant in test?
I think there is no error here, but probably we should use the same approach
There was a problem hiding this comment.
updated: af18208
There was a problem hiding this comment.
Thank You for your work, I`ll review
There was a problem hiding this comment.
@SKonstantinS waiting for your review ;)
|
merged into https://github.com/rarible/protocol-contracts/tree/RPC-132-minter-role branch for now, gonna merge into master soon, thanks! |
|
@NicolasMahe merged into master too |
|
@disenotov Question on Minter Access control: can you enable this after a contract has been deployed with isPrivate=false? It appears it is enabled by the isPrivate boolean, but I don't see an "enable" function to change the setting via any of the ABI's. What is the name of the function to enable it? I can access the MinterAccessControl functions (isMinter, addMinter etc). |
|
@bobwith2bees Hello! do you want to switch isPrivate from false to true? if so, then it's not possible. We designed it so public collections can't become private or vice versa. |
|
@disenotov That's what I needed to know. Thanks for the clarification. |
Hey guys,
This PR is the implementation of suggestions from the discussion of my business partner: rarible/protocol#11 and is the phase 2 of the proposal https://gov.rarible.org/t/proposal-to-optionally-restrict-the-mint-of-tokens/182.
This PR adds a new smart contract,
MinterAccessControl, to restrict who can mint tokens.The state variable
_minterscontains the addresses that are authorized to mint.Functions
grantMinterandrevokeMinteradd or remove an address to/from the authorized minter list. Only the smart contract's owner can execute these functions.The state variable
minterAccessControlEnabledcontrols the restriction of mint.falseby default not to create breaking change.Functions
enableMinterAccessControlanddisableMinterAccessControlenable and disable the restriction of mint. Only the smart contract's owner can execute these functions.Finally, the function
isValidMinterasserts if the minter is authorized only if the mint restriction is enabled. Return true for any minter if the mint restriction is disabled.This function is called in the
mintAndTransferfunction of the contractsERC721LazyMinimalandERC721Lazyusing the minter encoded in thetokenId.The
MinterAccessControlrestriction is disabled by default the prevent breaking change. The contract owner has to callenableMinterAccessControland add the minter's address withgrantMinterfunction.