This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
fix builds for csi-* build.make.patch with FULL_LDFLAGS #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-attacher#268 Signed-off-by: Andrew Zammit <[email protected]>
…aspbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-provisioner#515 Signed-off-by: Andrew Zammit <[email protected]>
…patibility, raspbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/external-snapshotter#437 Signed-off-by: Andrew Zammit <[email protected]>
…aspbernetes#205 In the upstream build.make, line 74 was pushed to line 79 and the FULL_LDFLAGS abstraction was introduced. See kubernetes-csi/node-driver-registrar#118 Signed-off-by: Andrew Zammit <[email protected]>
zamnuts
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Failed csi-* image builds due to upstream's upstream
release-toolsupdate which introduced an abstraction forFULL_LDFLAGS. This caused raspbernetes'build.make.patchdiffs to be rejected (conflict).Checklist
Issue Ref
Fixes #205
Notes
See also #204 which fixes
csi-external-resizer. All csi-* builds require an identical fix, and this PR fixes the remaining.