Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This if() condition checks the result of seek, write, flush and fsync. The first three are methods on QFile, so return a truthy value on success. write() returns number of bytes written while seek() and flush() return bool true on success. Therefore they have to be inverted to detect errors. However, fsync() is a posix system call, so it returns zero (false) on success. Therefore it should not be inverted. Note that currently this entire code block can never run. knownsize is always zero because QFile.size() currently cannot determine the size of a block device. However, when I asked to confirm this behavior, a Qt maintainer decided to implement it, so there is now a PR. If that is released then this code block will become live and the reversed fsync check will cause a problem. PR: https://codereview.qt-project.org/c/qt/qtbase/+/581443
- Loading branch information