Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify experiment binaries with rattests #222

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

smnaugle
Copy link
Contributor

@smnaugle smnaugle commented Jan 8, 2025

Add in command line argument to specify which experiment binary should be used with the rattests. This is useful because it allows for downstream experiments to use the rattests framework while running their tests using their own experiment binary.

Copy link
Contributor

@JamesJieranShen JamesJieranShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the small change here. Thanks Sam!

python/rattest.py Outdated Show resolved Hide resolved
@tannerbk tannerbk merged commit acf82a1 into rat-pac:main Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants