Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CRL description #132

Merged
merged 11 commits into from
Jan 15, 2025
Merged

docs: update CRL description #132

merged 11 commits into from
Jan 15, 2025

Conversation

junczhu
Copy link
Contributor

@junczhu junczhu commented Dec 13, 2024

Add CRL description into notation verifier description, sharing more context about the revocation check workflow.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for ratify-dev ready!

Name Link
🔨 Latest commit 44c484f
🔍 Latest deploy log https://app.netlify.com/sites/ratify-dev/deploys/6785b541c9b9e90008eefc3b
😎 Deploy Preview https://deploy-preview-132--ratify-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Juncheng Zhu <[email protected]>
@junczhu
Copy link
Contributor Author

junczhu commented Dec 23, 2024

Need add TOC for the paragraph

Signed-off-by: Juncheng Zhu <[email protected]>
@junczhu junczhu marked this pull request as ready for review December 23, 2024 23:12
Signed-off-by: Juncheng Zhu <[email protected]>
@junczhu
Copy link
Contributor Author

junczhu commented Dec 23, 2024

Need add TOC for the paragraph

There is a table of content list in the side bar:
image

Signed-off-by: Juncheng Zhu <[email protected]>
susanshi
susanshi previously approved these changes Jan 7, 2025
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@junczhu junczhu requested a review from FeynmanZhou January 8, 2025 03:41
@FeynmanZhou FeynmanZhou added this to the v1.4.0 milestone Jan 9, 2025
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
Signed-off-by: Juncheng Zhu <[email protected]>
FeynmanZhou
FeynmanZhou previously approved these changes Jan 10, 2025
Copy link
Collaborator

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

binbin-li
binbin-li previously approved these changes Jan 13, 2025
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Juncheng Zhu <[email protected]>
@junczhu junczhu dismissed stale reviews from binbin-li and FeynmanZhou via 1155f2f January 14, 2025 00:51
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @junczhu

@FeynmanZhou FeynmanZhou merged commit 1ed1ddd into ratify-project:main Jan 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants