-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add certStoreManager interface to wrap operations on namespaced certStores [multi-tenancy PR 5] #1382
feat: add certStoreManager interface to wrap operations on namespaced certStores [multi-tenancy PR 5] #1382
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1382 +/- ##
===========================================
+ Coverage 65.31% 65.52% +0.21%
===========================================
Files 105 109 +4
Lines 5458 5570 +112
===========================================
+ Hits 3565 3650 +85
- Misses 1535 1565 +30
+ Partials 358 355 -3 ☔ View full report in Codecov by Sentry. |
b206dc3
to
1904b01
Compare
1904b01
to
bedadfa
Compare
29322ca
to
1e62aca
Compare
1e62aca
to
f3f2d13
Compare
1d3450e
to
b22785c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. thanks!
Description
What this PR does / why we need it:
This is the 5th PR for multi-tenancy support. Please review #1380 first. Check diff between PR 4 and PR 5 at: binbin-li#120
CertificatesMap
under controllers to resource_map.go so that it can be shared by clustered and namespaced controllers in the future.Note:
The nested certStore map is like:
We keep the namespace prefix for inner map key to faciliate accessing from verifier.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change