fix(tls): allowing TLS when crd-manager disabled

[JoupainMD]

Description

What this PR does / why we need it:

Allowing usage of TLS when --enable-crd-manager is not set.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have created a self signed certificate using the following commands:

openssl genrsa -out server.key 2048 ##gen key
openssl req -new -x509 -sha256 -key server.key -out server.crt -days 3650 ## gen cert

Then test using the following args:
docker run -p 6001:6001 -v ${PWD}/server.crt:/usr/local/tls/tls.crt -v ${PWD}/server.key:/usr/local/tls/tls.key -v ${PWD}/config.json:/app/config/config.json ratify --http :6001 -c /app/config/config.json --cert-dir="/usr/local/tls" --debug

It looks like RATIFY_CERT_ROTATION feature flags is not taken into account also when you don't use the --enable-crd-manager arg.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
httpserver/server.go	0.00%	3 Missing ⚠️

Files with missing lines	Coverage Δ
httpserver/server.go	42.74% <0.00%> (-0.71%)	⬇️

[binbin-li]

@JoupainMD thanks for the fix! I'm just curious what's the user scenario that crd-manager is off.

[JoupainMD]

@JoupainMD thanks for the fix! I'm just curious what's the user scenario that crd-manager is off.

today, our use case is to use ratify as a external_data provider for Gatekeeper, to enforce notation signature on docker images.

We use ratify with a config file loaded via a ConfigMap, we don't plan on using CRD to be honest as it is more painful for us than useful (the simple ConfigMap is ok today). We could have use CRD too but it would have mean giving specific accesses to the ratify service account to create / update CRD and we try to keep it really simple.

[binbin-li]

changes lgtm, thanks for the fix!

[susanshi]

Hi @akashsinghal , do we have an issue to track kmpprovider support for configmap?

[binbin-li]

Hi @akashsinghal , do we have an issue to track kmpprovider support for configmap?

there is an issue tracking CLI, #1300. Probably we can address both in the issue since configMap is similar to the config for CLI