Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the script to download certs and apply azure policy operation on … #2054

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

shahramk64
Copy link
Contributor

Description

What this PR does / why we need it:

This PR adds a script that will download certificates from a list of urls, and converts them to .pem format. It also applies the operations needed for azure policy on an AKS cluster, which will be used as part of the ratify+aks package on the azure marketplace

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1964

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@shahramk64 shahramk64 changed the title add the script to download certs and apply azure policy operation on … chore: add the script to download certs and apply azure policy operation on … Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

@shahramk64 shahramk64 force-pushed the skalantari/ratify-aks-on-azure-marketplace branch 3 times, most recently from 55e2cff to 911f222 Compare January 31, 2025 03:19
ratify-on-azure.sh Fixed Show fixed Hide fixed
@shahramk64 shahramk64 force-pushed the skalantari/ratify-aks-on-azure-marketplace branch 24 times, most recently from 3b27514 to 283efa7 Compare February 3, 2025 03:20
@shahramk64 shahramk64 force-pushed the skalantari/ratify-aks-on-azure-marketplace branch 7 times, most recently from 099f4d1 to b46a308 Compare February 3, 2025 23:36
echo "clientId: $clientId"

# Install Helm
curl -s https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 9: downloadThenRun not pinned by hash
Click Remediation section below to solve this issue
@shahramk64 shahramk64 force-pushed the skalantari/ratify-aks-on-azure-marketplace branch 5 times, most recently from a72df29 to 33ee91b Compare February 4, 2025 00:23
@shahramk64 shahramk64 force-pushed the skalantari/ratify-aks-on-azure-marketplace branch from 33ee91b to 943616f Compare February 4, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify inline KMP Resources creation during Ratify installation
1 participant