Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plugins as OCI artifacts #519
feat: plugins as OCI artifacts #519
Changes from 8 commits
66b1f84
027e13f
26178a1
2a356df
b5d3601
cf3ae07
7a1e73c
cd6834b
37a852c
1d7a209
82bb22d
a38067c
f747d6b
2cdfffc
987e088
76df183
f2f3a86
9bf4994
68beaeb
32d73aa
a733749
f1633e9
2f2bc71
bee82cb
da3dcbd
396160e
f898518
675989c
c711d12
6fcc37a
712083a
5c6b340
9978da5
b343f44
32653ae
65f9ab6
3b3196c
0f36bd9
f11c38a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: what should the config look like for specifying auth for pulling plugins. Should look & feel similar to
oras
store config, - but plugins might (will probably?) come from a different registry than application imagesPerhaps the config should read something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we need to restructure our auth config. Curious do you think customer will use same identity for plugins /artifacts / certs from keyvault or will they use different clientIds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late follow-up: I would expect to use the same app identity here, at least in Azure
So if you pulled plugins from a different registry than runtime images: it would still be the one "Ratify" Managed Identity that has AcrPull on both the "plugin registry" and the "normal one"